[ 
https://jira.duraspace.org/browse/DS-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23344#comment-23344
 ] 

Richard Rodgers commented on DS-1082:
-------------------------------------

Hi Kevin

I think it is debatable whether this is a bug at all: the design intent was to 
err on the side of caution, since once content is installed, we can't go 
backwards in time and place it under embargo. The thought was that if there was 
data in the embargo field, that was a fairly strong (but not absolute, of 
course) indication of a desire to place it under embargo. For example, if I 
mistype a date by one digit, I'm not sure the system should install the item 
anyway (whether or not an admin is notified). I completely agree that throwing 
an exception is a somewhat inelegant solution, but item install time is not 
always interactive, so there may be no web user to put an error in front of. 
                
> Invalid embargo causes item archival to crash.
> ----------------------------------------------
>
>                 Key: DS-1082
>                 URL: https://jira.duraspace.org/browse/DS-1082
>             Project: DSpace
>          Issue Type: Bug
>            Reporter: Kevin Van de Velde
>            Assignee: Kevin Van de Velde
>             Fix For: 1.8.1
>
>         Attachments: embargo-fix.patch
>
>
> When an item is archived & the embargo date is invalid (either an invalid 
> date has been entered as embargo date or the embargo date has already passed) 
> the item cannot be archived since the embargo manager will throw an invalid 
> argument exception.
> In the attached patch is a possible solution for this problem (catching the 
> exception & logging the error), however I wonder should an email be sent to 
> alert the admin that an invalid embargo was entered ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to