[ 
https://jira.duraspace.org/browse/DS-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24472#comment-24472
 ] 

Mark Diggory commented on DS-1144:
----------------------------------

Taking a look at this work. First off, I like the idea a lot. A few immediate 
concerns/questions though: 

> 1) A bit nit-picky, but I'm not a fan of the name 'dspace-common-api'. This 
> looks to be the idea of 
> the "business logic api". I'd rather this be named something like 
> "dspace-ui-logic-api" or "dspace-business-api" 
> or "dspace-common-ui-api" (or something else). Essentially, the name 
> "-common-api" to me implies 
> it is used *everywhere* in DSpace. But, obviously it's not "common" across 
> everything in DSpace.
> It's really UI specific. 

Ok, in the meantime I dropped the project name. We still have 

https://github.com/DSpace/DSpace/tree/maven-project-consolidation/dspace-stats
https://github.com/DSpace/DSpace/tree/maven-project-consolidation/dspace-discovery-solr

The sword-client was consolidated entirely into xmlui and org.purl.sword was 
left in dspace-sword

> 2) I'm wondering what the logic is behind keeping "dspace-discovery-solr" as 
> a standalone top-level project? 
> Why does the "dspace-sword-client" project get swallowed into the 
> "dspace-common-api" while the 
> "dspace-discovery-solr" does not? Both of these projects seem similar, in 
> that they are XMLUI 
> specific currently, but in the future may be expandable to other UIs. 

Because its a plugin for discovery, elastic-search will be another in the near 
future. (We should review this with Peter and Kevin on Wednesday)
                
> Maven Project Consolidation
> ---------------------------
>
>                 Key: DS-1144
>                 URL: https://jira.duraspace.org/browse/DS-1144
>             Project: DSpace
>          Issue Type: Improvement
>            Reporter: Mark Diggory
>            Assignee: Mark Diggory
>            Priority: Major
>             Fix For: 3.0
>
>
> https://wiki.duraspace.org/display/DSPACE/Maven+Project+Consolidation
> This project would reorganize and consolidate some of the maven project 
> hierarchy to reduce the number of maven projects neccessary to operate DSpace.
> Benefits: Reduce the number of maven projects in DSpace "Core" from 39 to 19.
> GitHub Branch for this is located here: 
> https://github.com/DSpace/DSpace/tree/maven-project-consolidation
> This project would consolidate:
> dspace-xmlui
>    dspace-xmlui-wing
>       src/main/java
>    dspace-xmlui-api
>       src/main/java
>       src/main/resources
>    dspace-xmlui-webapp
>       src/main/resources
>       src/main/webapp
> and it would reduce it down to
> dspace-xmlui
>    src/main/java
>    src/main/resources
>    src/main/webapp
> We would utilize the current model found in dspace-swordv2 
> (http://scm.dspace.org/svn/repo/dspace/trunk/dspace/modules/swordv2)
> dspace-swordv2
>    src/main/java
>    src/main/resources
>    src/main/webapp

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to