[ https://jira.duraspace.org/browse/DS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark H. Wood resolved DS-844. ----------------------------- Resolution: Fixed > Simplify, internationalize org.dspace.statistics.util.LocationUtils > ------------------------------------------------------------------- > > Key: DS-844 > URL: https://jira.duraspace.org/browse/DS-844 > Project: DSpace > Issue Type: Improvement > Components: DSpace API > Affects Versions: 1.7.0 > Reporter: Mark H. Wood > Assignee: Mark H. Wood > Fix For: 3.0 > > Original Estimate: 0 minutes > Remaining Estimate: 0 minutes > > Most of the class consists of long one-dimensional String arrays which (a) > must be kept parallel and (b) only give English names. Names of countries > are already in the JRE, in java.util.Locale, where they are also > internationalized. For example, to get the French name for China: new > Locale("ZH","CN").getDisplayCountry(new Locale("FR","FR")); > LocationUtils.getCountryName() could use > Locale.getDisplayCountry(request.getLocale()) to replace this private table > and internationalize its return. > This leaves only the mapping from country to continent and the names of the > continents. The mapping should be externalized to e.g. a Properties file or > Spring map-property injection where it can be updated without recompilation. > The continents' names should be externalized to localized property bundles > such as Messages*.properties so they can be internationalized. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.duraspace.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel