[ https://jira.duraspace.org/browse/DS-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26409#comment-26409 ]
Kevin Van de Velde commented on DS-1210: ---------------------------------------- Pull request: https://github.com/DSpace/DSpace/pull/95 > NullPointerException on /search-filter without field param > ---------------------------------------------------------- > > Key: DS-1210 > URL: https://jira.duraspace.org/browse/DS-1210 > Project: DSpace > Issue Type: Bug > Components: Discovery > Affects Versions: 1.8.2 > Reporter: Nestor Oviedo > Assignee: Kevin Van de Velde > Labels: Discovery, NullPointerException, search-filter > Fix For: 3.0 > > > When a user issues a request to "/search-filter" without the "field" > parameter, a NullPointerException is thrown. This is because the > "org.dspace.app.xmlui.aspect.discovery.SearchFacetFilter" class takes this > parameter from the request and just uses it, whitout checking if it is null > first. > A possible fix to this would be to add a setup() method to the > SearchFacetFilter. This method should check for any param called "field" and > throw an exception when there is no parameter with that name. This exception > should be handled in the sitemap and a 400 "Bad request" status should be > returned to the client. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel