Steve Swinsburg created DS-1391:
-----------------------------------

             Summary: build should check for and require Ant 1.8+
                 Key: DS-1391
                 URL: https://jira.duraspace.org/browse/DS-1391
             Project: DSpace
          Issue Type: Bug
            Reporter: Steve Swinsburg


There is a check in the build.xml for whether or not to overwrite configs (see 
the unless attribute):

<target name="copy_configs_keep" unless="${overwrite}" 
depends="prepare_configs">

The problem is, property expansion was only added in Ant 1.8. Previously it 
only accepted property names, and if they were set or not set, to any value.

So using Ant 1.7.1 on DSpace 1.8 or higher causes those targets to always be 
executed, even if overwrite=false. 

The reason we are using Ant 1.7.1 is due to other projects requiring it, so we 
didn't think to upgrade.

What would be good (and IMO required to fix this problem) is for the build.xml 
to check the version of Ant and fail the build if using a version of Ant < 1.8, 
since that version is required for the build to function as expected.

This is as simple as a target that runs before all others to check the Ant 
version string. I can send a pull request for this if this functionality is 
desired.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to