[
https://jira.duraspace.org/browse/DS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26899#comment-26899
]
Tim Donohue commented on DS-1392:
---------------------------------
Just posted Pull #132, which implements the fix described in #2 above.
https://github.com/DSpace/DSpace/pull/132
I think this is working fine, and should be fine to add to 3.0.
> Cannot run a Maven license header check from any child module
> -------------------------------------------------------------
>
> Key: DS-1392
> URL: https://jira.duraspace.org/browse/DS-1392
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 3.0
> Reporter: Tim Donohue
> Assignee: Tim Donohue
> Fix For: 3.0
>
>
> If you attempt to run a license header check from any subdirectory/submodule,
> it will fail since the "LICENSE_HEADER" file is referenced by a relative path
> in the 'dspace-parent' POM:
> https://github.com/DSpace/DSpace/blob/master/pom.xml#L124
> Although this may not seem to be a big deal, it's a bit annoying for NetBeans
> users, as by default NetBeans likes to run a "mvn install" (instead of "mvn
> package") which always runs a license header check.
> There are two possible fixes, that I've come up with:
> (1) We reference the LICENSE_HEADER via it's URL in GitHub
> (https://raw.github.com/DSpace/DSpace/master/LICENSE_HEADER). This ensures
> the path is always valid...but, unfortunately it means that errors could
> occur if GitHub is down (as this will tell Maven to go download it from
> GitHub each time).
> (2) We tweak the POMs such that they all properly refer to the LICENSE_HEADER
> file by a relative path.
> I've found a way to do #2, but it unfortunately means a small update to every
> single POM (as they all need to know the relative path to the [dspace-src]
> root folder, in order to reference the LICENSE_HEADER file). I'll post a
> Pull Request shortly for review.
> If there are any concerns we can always just go with the URL option for 3.0
> -- it definitely works...it's just not necessarily ideal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
