[
https://jira.duraspace.org/browse/DS-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28075#comment-28075
]
Ivan Masár commented on DS-1546:
--------------------------------
Hi, just a notes from some Czech users who have encountered this or a similar
problem (I didn't look at it):
1) The findMultipleHeaders method expects multiple values separated by ";"
while in reality it seems there is ":".
2)
- } else if (idx > 0 && values.charAt(idx-1) != '\\' {
+ } else if (idx > 0 && values.charAt(idx-1) == '\\' {
// The attribute starts with an escaped
semicolon
> org.dspace.authenticate.ShibAuthentication.findMultipleHeaders doesn't work
> for multiple headers, and provides incorrect config advice
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DS-1546
> URL: https://jira.duraspace.org/browse/DS-1546
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 3.1, 4.0
> Reporter: Hardy Pottinger
> Assignee: Hardy Pottinger
> Fix For: 4.0
>
>
> When Shibboleth returns multiple values for a header, such as
> SHIB-SCOPED-AFFILIATION, it delimits the values with semicolons. The code in
> org.dspace.authenticate.ShibAuthentication.findMultipleHeaders does not
> correctly handle such values, due to a minor logic error. I have a patch
> which I have confirmed fixes this issue (thanks to Mark Wood for his help in
> spotting the exact error). I will make a pull request soon, and will merge it
> myself, as this is a very minor, though important, change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
