[
https://jira.duraspace.org/browse/DS-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28493#comment-28493
]
Tim Donohue commented on DS-1589:
---------------------------------
Bram,
Just wanted to comment that this suggestion seems reasonable to me. It will
likely take some work to get correct (will require some coding where ever we
generate emails). But, the approach seems like a good one. I've often been
frustrated by the lack of flexibility in our email templates in general. As you
said you cannot share salutations and other common text across messages as it
is. Another possible benefit is it may be easier to replace all instances of
"DSpace" in those old email templates with the name of your site.
The Messages.properties file definitely seems to be the most appropriate
location for the reasons you mentioned.
Upgrades definitely may be a bit of a pain. But, hopefully most will find it to
be a worthwhile "pain" for the benefits.
> Put DSpace email messages into messages catalogs
> ------------------------------------------------
>
> Key: DS-1589
> URL: https://jira.duraspace.org/browse/DS-1589
> Project: DSpace
> Issue Type: Sub-task
> Components: JSPUI, XMLUI
> Reporter: Bram Luyten (@mire)
> Priority: Major
> Fix For: 4.0
>
>
> In order to allow translations by Translatewiki.net, it would be optimal if
> the email messages would also be represented as keys in the existing messages
> catalogs (Messages.properties for JSPUI or messages.xml for XMLUI).
> I propose to cut the existing email templates into different messages.
> As an additional benefit, things like the salutation can be centralized so
> that they will only need to be changed in a central location, instead of
> making these modifications in every single email template.
> On the downside, some effort will be required to migrate your old email
> templates into the new keys if you have already made customizations.
> Before diving into actual development for this, we would like to gather input
> on whether this is a good idea or not. Please do comment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
