Title: Message Title
|
|
|
|
The code is clearly wrong but I still see a possible use case for it.
I'm only guessing but... what happen if you rely on a db user with grants on more schema, maybe also database from different DSpace instances? In this scenario as we are doing all queries without specifying a schema the default schema is used and when a table is not available in such schema it is searched across all the schema that the db user can access.
So, in oracle you can configure via jndi a generic pool where the user is not specified, in such case we need this configuration to specify the actual schema.
In postres you could have a similar issue also without jndi just using an user like the postgres su and if you have more dspace db instances say dspace1 and dspace2 you need to specify a default schema.
We should make a test and probably fix the code replacing the isOracle statement with a isPostgres
https://github.com/mwoodiupui/DSpace/blame/ce9ca80080c1a869b3464fc2ca942a5a878e35b4/dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseManager.java#L59
|
|
|
|
|
|
|
I see this in initialize():
if (isOracle)
{
if (StringUtils.isEmpty(ConfigurationManager.getProperty("db.postgres.schema")))
{
sqlOnBorrow = "SET SEARCH_PATH TO " + ConfigurationManager.getProperty("db.postgres.schema").trim();
}
}
Two things seem odd:
o It's doubtful that this would ever do ...
|
|
|
|
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
