Yea, Graham has the history right. :) Several of the longstanding 
Committers were around in 2007 when this discussion/decision occurred, 
as you can see from that thread.

As noted in that thread (and as I can best recall), the decision was to 
*replace* DCValue with MetadataValue and deprecate it after all 
refactoring was complete. Unfortunately, the actual refactoring work has 
never really been done. As it stands, MetadataValue is not really  a 
valid replacement for DCValue (MetadataValue is more for database access 
to the 'metadatavalue' table). So, DCValue is still in use all over the 
codebase. Unfortunately, we deprecated DCValue without actually doing 
much work towards removing it.

To clarify my initial +1 : I actually was NOT voting to immediately 
un-deprecate (right now in 4.x/4.1).  Rather, I was voting to 
un-deprecate in 5.0. That also looks to be the goal of the ticket that 
Mark W created:
https://jira.duraspace.org/browse/DS-1883

So, I agree with Graham's points here. We shouldn't actually 
un-deprecate until 5.0, if need. But, it's good to be discussing this 
*now* so that we have plenty of time to potentially refactor DCValue out 
of the 5.0 codebase. If the refactoring occurs, then deprecation will 
remain. If not, then we should remove deprecation until we are able to 
do the necessary refactoring.

In many ways this whole issue is really just a Java class name issue. 
DCValue shouldn't have "DC" in the name as it's NOT just for Dublin 
Core.  As a "quick fix" a simple rename/refactor of "DCValue" to a 
generic name (e.g. "MetadataEntry", as in reality "DCValue" doesn't 
represent just a "value", it contains information about an entire 
Metadata Entry) may even be sufficient.

- Tim

On 1/27/2014 7:53 AM, Graham Triggs wrote:
> What, you mean like this? :)
>
> http://sourceforge.net/mailarchive/forum.php?thread_name=20070424182230.GA28212%40pomona.hpl.hp.com&forum_name=dspace-devel
>
>
> On 27 January 2014 12:09, helix84 <heli...@centrum.sk
> <mailto:heli...@centrum.sk>> wrote:
>
>     How about before voting we first try to find out the reasons why it
>     was deprecated (as Graham started) and then decide to either rewrite
>     or un-deprecate it (again, as Graham suggested)? There's still plenty
>     of time to do something about it - and this is the best time to start.
>
>     Git blames James Rutherford for adding the annotation:
>     
> https://github.com/DSpace/DSpace/blame/master/dspace-api/src/main/java/org/dspace/content/DCValue.java#L20
>
>     Any ideas how to contact him? What about other developers who were
>     active at that time?
>
>
>     Regards,
>     ~~helix84
>
>     Compulsory reading: DSpace Mailing List Etiquette
>     https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette
>
>

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to