I am not getting this. Now processFinally is called always - after exception and after normal execution - and it always generates 500 "INTERNAL_SERVER_ERROR". It is true that in addition it aborts the context, but . . .
On Tuesday, February 23, 2016 at 10:29:30 PM UTC+2, Peter Dietz wrote: > > Look at Git Blame to find out why things changed: > > https://github.com/DSpace/DSpace/blame/dspace-5_x/dspace-rest/src/main/java/org/dspace/rest/HandleResource.java > > And that line leads to: > https://github.com/DSpace/DSpace/pull/1007 > > So, adding that was intending to prevent stale connections / contexts from > being held open for a very long time, and behave like other endpoints. The > problem was that you could view /rest/handle, and get data, then change > that object, and the next time you view that /rest/handle, the data would > not have changed. > > If you have a stack trace, please consider investigating the root of the > bug for 5x. In the upcoming DSpace 6x, contexts are completely different > with the services refactor, and changes here would have limited utility. > > > ________________ > Peter Dietz > Longsight > www.longsight.com > pe...@longsight.com <javascript:> > p: 740-599-5005 x809 > > On Tue, Feb 23, 2016 at 3:19 PM, Evgeni Dimitrov <dimitr...@gmail.com > <javascript:>> wrote: > >> Comparing 5.2 and 5.4 - org.dspace.rest.HandleResource - I see that after >> the line: >> >> return new Community((org.dspace.content.Community) dso, expand, context); >> >> some lines are added: >> >> } finally{ >> processFinally(context); >> } >> >> Because context is not null and valid, processFinally generates 500 >> "INTERNAL_SERVER_ERROR" >> >> What was the intention for adding "finally" there? What should be the >> fix? I can just delete these lines . . . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "DSpace Technical Support" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to dspace-tech...@googlegroups.com <javascript:>. >> To post to this group, send email to dspac...@googlegroups.com >> <javascript:>. >> Visit this group at https://groups.google.com/group/dspace-tech. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group. To unsubscribe from this group and stop receiving emails from it, send an email to dspace-tech+unsubscr...@googlegroups.com. To post to this group, send email to dspace-tech@googlegroups.com. Visit this group at https://groups.google.com/group/dspace-tech. For more options, visit https://groups.google.com/d/optout.
