Dear Glenn,
We were able to reproduce your problem by creating the patch through the GitHub UI compare. The problem is that it comes through as straight text this way, whereas we would need a .patch file if we want the file with the ORCID badge to be included as well. To mitigate the issue, we have created the relevant patch files for both DSpace 5 and 6. We have also updated the download link in the patch documentation so that it links to those patches instead of the compare view. For reference, here is the link for the DSpace 6 version: https://github.com/atmire/expanded-ORCID-support/blob/master/patches/dspace_6x.patch . In case you would like to create the patch yourself, you can find the instructions on how to do this here: https://atmire.github.io/expanded-ORCID-support/#/prerequisites?id=download-patch . If you try to apply the patch with the .patch file, the ORCID badge file should be added correctly. Please do let me know if this does not work. Best wishes, Jolien On Tuesday, January 21, 2020 at 10:36:18 AM UTC+1, Jolien (Atmire) wrote: > > Hi again Glenn, > > > Sorry to hear it didn’t work. We’ll try to reproduce your problem on a > fresh instal, that may help to trouble shoot further. I’ll keep you > informed! > > > Best, > > > Jolien > > On Friday, January 17, 2020 at 10:58:03 PM UTC+1, Glenn G wrote: >> >> Hello, Jolien, >> >> I applied the patch to my restored test system today, but unfortunately >> the results are the same, even with the orcid_icon.png file in place before >> and after running the patch. When I submit a test document, I can select >> an author with an ORCID ID and add her to the item submission. When I >> click the button to submit the item, it takes more than 90 seconds to >> acknowledge the submission. After the item is submitted, no ORCID icon >> appears by the author's name and the name is not clickable. >> >> Thanks for any help. >> Glenn >> >> On Tuesday, January 14, 2020 at 4:33:13 AM UTC-6, Jolien (Atmire) wrote: >>> >>> Hi Glenn and Alex, >>> >>> Thanks for checking. The orcid_icon.png file should have been added into >>> the right folder automatically when you installed the patch, hence my >>> question about the path. I'll try to do the installation on a vanilla >>> DSpace again to see if it renders the same problem for me. If so, we'll >>> make sure to get this fixed. >>> >>> To already fix the issue on your DSpace right now, you can indeed just >>> download the file and add it to >>> [dspace]/webapps/xmlui/themes/Mirage2/images as Alex already suggested. If >>> that does not work, let me know. >>> >>> Best, >>> >>> Jolien >>> >>> On Monday, January 13, 2020 at 5:52:25 PM UTC+1, Alex Fletcher wrote: >>>> >>>> Glenn: >>>> >>>> I downloaded the orcid_icon.png file that Jolene mentioned earlier and >>>> put it here: >>>> >>>> - [dspace]/webapps/xmlui/themes/Mirage2/images >>>>> >>>> >>>> That seemed to do the trick for us. >>>> >>>> Alex >>>> >>>> >>>> On Monday, 13 January 2020 11:11:12 UTC-5, Glenn G wrote: >>>>> >>>>> Jolien, >>>>> >>>>> Our DSpace installation does not have the path you mentioned. The >>>>> Mirage2 directory is located here: >>>>> >>>>> [dspace]/webapps/xmlui/themes/Mirage2 >>>>> >>>>> Our [dspace] directory is not literally "dspace". It has the format, >>>>> id-dspace. Also, our modules directory is located here: >>>>> >>>>> [dspace]/config/modules >>>>> >>>>> There are various possible reasons why our installation is different >>>>> from that anticipated by the patch: >>>>> >>>>> - It has been upgraded multiple times. >>>>> - It was moved to a standalone server after being hosted on a server >>>>> with several other DSpace installations. >>>>> - It was originally upgraded to 6.3 using the binary install. I added >>>>> the [dspace-source] later in order to install patches. >>>>> >>>>> Nonetheless, Alex indicates the patch could be installed if I do one >>>>> or both of the following beforehand: >>>>> >>>>> - Put a copy of orcid_icon.png in [dspace]/webapps/xmlui/themes/Mirage2 >>>>> - Create a directory, >>>>> [dspace]/modules/xmlui-mirage2/src/main/webapp/themes/Mirage2 and put >>>>> orcid_icon.png there. >>>>> >>>>> Does either approach seem reasonable? >>>>> >>>>> Thanks, >>>>> Glenn >>>>> >>>>> On Monday, January 13, 2020 at 2:16:51 AM UTC-6, Jolien (Atmire) wrote: >>>>>> >>>>>> In fact, the file should be contained in the patch. You can see that >>>>>> here (for the DSpace 6 version): >>>>>> https://github.com/atmire/expanded-ORCID-support/blob/stable_6x/dspace/modules/xmlui-mirage2/src/main/webapp/themes/Mirage2/images/orcid_icon.png. >>>>>> >>>>>> For some reason, it looks like it is not accessed correctly when you do >>>>>> the >>>>>> installation. >>>>>> >>>>>> What could be happening is that in your DSpace installation, the path >>>>>> dspace/modules/xmlui-mirage2/src/main/webapp/themes/Mirage2 does not >>>>>> exist >>>>>> or exists under a different name. Could you check that? >>>>>> >>>>>> On Tuesday, December 3, 2019 at 12:10:42 AM UTC+1, Glenn G wrote: >>>>>>> >>>>>>> After applying the ORCID patch, the functionality my users were most >>>>>>> interested in is missing. The ORCID logo does not appear next to the >>>>>>> author's name, and the name is not clickable, so a list of the author's >>>>>>> publications cannot be retrieved from ORCID as promised. The ability >>>>>>> to >>>>>>> search by ORCID number does now appear in the list of search modifiers, >>>>>>> but >>>>>>> it only works when the entire number is supplied with the "equals" >>>>>>> operand. The patch and functionality are described here: >>>>>>> https://atmire.github.io/expanded-ORCID-support/#/ >>>>>>> >>>>>>> If you have any idea why the logo and linked name don't appear, >>>>>>> please let me know. We are using the Mirage 2 theme. >>>>>>> >>>>>>> Thanks, >>>>>>> Glenn >>>>>>> >>>>>> -- All messages to this mailing list should adhere to the DuraSpace Code of Conduct: https://duraspace.org/about/policies/code-of-conduct/ --- You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group. To unsubscribe from this group and stop receiving emails from it, send an email to dspace-tech+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/dspace-tech/20d7b46e-3a83-473a-b891-88b2eb3ffd39%40googlegroups.com.
