Thanks Agustina. I read those comments, and that was where I was headed next, but I thought I'd double check with folks here before I got started. Partly because of this statement "This part of the code might be refactored in a subsequent release, so this is kind of a temporary solution.". But it's reassuring to know others are using the same strategy.
I mean..... if you had some code or tips to share, I wouldn't turn that down. :) I've done a bit of work with Vue but, like you, Angular is new to me. I welcome any help I can get. As for workflow, we started with a Git clone, then created a local branch from the 7.2 release, to keep our customizations separate. My plan is to then merge the 7.3 release into my branch to keep it up to date. By starting with a copy of the custom theme though, I'll need to manually move any 7.3 changes to "custom" into my theme, so I'm wondering if that that copy was a good decision, and whether I should have just made changes directly to "custom". I too welcome any suggestions on the best way to manage things going forward. Thanks again Agustina! - Darryl On Wednesday, May 4, 2022 at 6:12:03 AM UTC-6 Agustina Martinez wrote: > Hi Darryl, > > We are currently at the same stage as you are regarding custom theming. I > have opted for now to take a copy of the custom theme and use it as the > basis for our institutional theme (to make updates a bit easier going > forward I've removed all of those customisations from the custom theme that > we do not use for now). But like you, do not know whether this is the best > approach. I found the documentation pages really good: > https://wiki.lyrasis.org/display/DSDOC7x/User+Interface+Customization and > in particular the comments at the end answer your question about > customising components such as the "untyped item". I have successfully done > that in our test instance and happy to share with you if you don't get it > working based on the info in the docs pages. > > It would be great if someone could comment on best ways forward for > customising in ways that make future upgrades simpler. I am really knew to > angular so just slowly finding our ways! > > Agustina > > On Tuesday, 3 May 2022 at 21:02:24 UTC+1 darryl....@usask.ca wrote: > >> >> How are people theming DSpace 7.x? Is it better to create a new theme >> from a copy of "custom" (and deal with integrating any future changes made >> to "custom" manually), or just create a local branch of the dspace-angular >> repo and modify the "custom" theme directly (and then pull in changes to >> "custom" via a merge request from the main branch)? >> >> Also, can anyone point me in the right direction to make changes to the >> simple item view? It seems the default for items in DSpace is "untyped >> item" (I haven't enabled any of the entity stuff). I've modified >> src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html >> to get the results I want, but it seems like a bad idea to modify the >> global code rather than something in my theme. >> >> The "custom" theme contains simple page templates for Publication items, >> -- src/themes/limestone/app/item-page/simple/item-types/publication -- but >> not untyped items. Simply copying the "untyped-item" folder from the >> global code into that "item-types" folder didn't seem to work. I assume >> there some additional changes required in a .ts file somewhere I also need >> to update, but I'm, not quite sure which ones. Or do I need to copy the >> entire src/app/item-page directory tree into my theme? >> >> Unless there's some other (easier) way to add additional metadata fields >> to the simple display that I've not discovered?? >> >> Thanks, >> >> - Darryl >> >> >> >> ---------- >> *Darryl Friesen, BSc* >> Programmer/Analyst >> *University of Saskatchewan* >> *ICT / University Library* >> >> >> -- All messages to this mailing list should adhere to the Code of Conduct: https://www.lyrasis.org/about/Pages/Code-of-Conduct.aspx --- You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group. To unsubscribe from this group and stop receiving emails from it, send an email to dspace-tech+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/dspace-tech/b0519090-eeaa-4f02-b27e-5964f6ba2ecdn%40googlegroups.com.
