Bug Tracker item #2829650, was opened at 2009-07-30 14:38 Message generated for change (Comment added) made by csmr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=2829650&group_id=250683
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: daemon Group: v3.9.0 Status: Open Resolution: None Priority: 9 Private: No Submitted By: Carlo Rodrigues (csmr) Assigned to: Stevan Bajic (sbajic) Summary: group matching broken (relative to ID: 2823000 ) Initial Comment: I tried to reopen bug 2826644, but couldn't. Commit 0396abc4d731279cefbb440ba008eac726e56615 breaks group matching. On line strncmp(user,"*@",2) == 0 && strchr(username,"@") != NULL && strcasecmp(user+1,strchr(username,"@")) == 0)) the second argument to strchr must be a char, enclosed by ' ', not " ". I also noticed that you inverted the value of some tests, for example: - if (strcmp (u, username)) + if (strcasecmp (u, username) == 0) were these intentional? Cheers, Carlo Rodrigues ---------------------------------------------------------------------- >Comment By: Carlo Rodrigues (csmr) Date: 2009-07-30 15:06 Message: I just happened to notice the group matching wasn't working for groups with value "*...@something", everything was going to my default group. Then I was puzzled because at first it's hard to spot the difference between the '' and "". ---------------------------------------------------------------------- Comment By: Stevan Bajic (sbajic) Date: 2009-07-30 14:55 Message: Hallo Carlo > - if (strcmp (u, username)) > + if (strcasecmp (u, username) == 0) > > were these intentional? > NO! I made a mistake! Will fix asap. > the second argument to strchr must be a char, enclosed by ' ', not " ". > Boy! I should not code when it is late. Will fix that as well. Thanks god you are having an open eye on the commits. THANK YOU! Kind Regards Stevan Bajic ---------------------------------------------------------------------- Comment By: Carlo Rodrigues (csmr) Date: 2009-07-30 14:42 Message: It was relative to bug 2823000, not 2826644. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=2829650&group_id=250683 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Dspam-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspam-devel
