Bug Tracker item #2837915, was opened at 2009-08-15 00:30
Message generated for change (Comment added) made by sbajic
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=2837915&group_id=250683

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: daemon
Group: None
Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Franck Bourdonnec (franck78)
Assigned to: Stevan Bajic (sbajic)
Summary: bad variable used

Initial Comment:
in dspam.c function retrain_message() (~line 2620)
the 'result' integer is never used but passed to LOGDEBUG.....

Probably the interesting integer is CLX->result

Note also in this function two small fixes:

1)either choose "processorBias" or "ProcessorBias"

2)at the end of the function, in the test
if (ck_result || CLX->result==match)
ck_result is absolutly never true because of 
the preceding test 'returning' !!!





----------------------------------------------------------------------

>Comment By: Stevan Bajic (sbajic)
Date: 2009-08-15 14:05

Message:
One part is fixed now in GIT commit
cf7f3531406c3c2e8fafa957ccdca8fb54727447

----------------------------------------------------------------------

Comment By: Stevan Bajic (sbajic)
Date: 2009-08-15 01:01

Message:
Hallo Franck

The first issue (the one with result) has been fixed some while ago.
Please have a look at GIT commit 320a2a0ef51fe58665b6bd6b496a394d6d1a11b0

About the two other small fixes:
1) "processorBias" is used in the preference extension and "ProcessorBias"
is used in dspam.conf. It's handling the same issue but it's totally right
to check once for "processorBias" (when using preference extensions) and
check for "PocessorBias" when using dspam.conf

2) That issue as well has been fixed some while ago. Please check GIT
commit 9a6cdaba9caa1b951ccce77382262da7964a3f83


Please take the time to check out the GIT repository before posting more
bugs here that have been fixed already.


Kind Regards

Stevan Bajic

----------------------------------------------------------------------

Comment By: Franck Bourdonnec (franck78)
Date: 2009-08-15 00:56

Message:
"CTX->result" is better!?

Memory leak detected:
ck_result=dspam_process(CLX,null)
if ck_result != 0
    return
and CLX is not dspam_destroyed.


        CLX->signature = &ATX->SIG;
        ck_result = dspam_process (CLX, NULL);
        if (ck_result != 0) {
          dspam_destroy (CLX);
          return EFAILURE;
        }

        if (CLX->result == match)
          do_train = 0;
        CLX->signature = NULL;
        dspam_destroy (CLX);




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=2837915&group_id=250683

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Dspam-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspam-devel

Reply via email to