On 11/14/2009 03:27 PM, Steve wrote: > -------- Original-Nachricht -------- >> Datum: Sat, 14 Nov 2009 11:36:42 -0700 >> Von: "Nathanael D. Noblet"<[email protected]> >> An: [email protected] >> Betreff: Re: [Dspam-user] RPM/SPEC for DSPAM 3.9.0 BETA4 > > Hallo Nathanael, > > >> Well the package is on its way to review. I haven't integrated your >> webui language changes yet. We'll see what they come back with. >> >> Because of their guidelines I've made the following defaults. >> >> MYSQL, POSTGRES& SQLITE3 are enabled drivers by default. >> SYSLOG, LDAP& DAEMON are also enabled by default >> >> I was unsure if it would be wise to enable user home dirs or the large >> domain flags. I'm thinking large domain flags may be smart unless there >> is a performance penalty for using it with non-large domains..? >> >> I'm also unfamiliar with the user homedirs feature so left it disabled >> by default. >> >> >> The review request is here so you can follow along if you want. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=537587 >> > Your changes break the possibility to build DSPAM with just one statically > linked driver. Building with "rpmbuild --without mysql --without postgres > --without sqlite3 -ba dspam.spec" does not work.
Right, I never tested that part. Some of the changes I had made were personal some were for fedora guidelines. I removed the requirement for perl as they only want you to specify Requires: if rpm doesn't find that dependency on its own. I hadn't tested if it had yet. > I modified my old SPEC file to follow the style you had in place for Fedora. > Additionally I made all the other changes that I mentioned before and enabled > the possibility to build DSPAM with just one statically linked storage driver > (regardless which driver one is choosing to be linked statically). > > I was so free to enable large scale since it is beneficial for big > installations but does not disturb smaller installations. > > The comments on top (with/without) in your SPEC file are misleading. I > changed them as well to reflect the by default selected options. Right, I forgot to change those.. > Is it okay for you? Let me know if I can help in any other way. This looks pretty good. I'll run some of the rpmlint checks and update the spec file in the review request I sent them. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Dspam-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspam-user
