On Tue, Apr 22, 2008 at 02:22:58PM +0300, Ion-Mihai Tetcu wrote: > On Mon, 21 Apr 2008 13:30:03 -0400 > The Anarcat <[EMAIL PROTECTED]> wrote: > > > On Mon, Apr 21, 2008 at 09:55:37AM +0300, Ion-Mihai Tetcu wrote: > > > I object to including to config changes: > > > - I don't see the need for it, dspam's .conf file is simpler/shorter > > > enough to need more that one file. > > > > It's simple: it makes it easier to package dspam into seperate > > functionalities. For example, the debian package has a seperate package > > for mysql support, that creates a file in the .d directory and > > configures the mysql driver. > > I see. > > > > - it brings in unneeded overhead (dir/file reading) > > > > overhead?? how much overhead is it, actually, to read one directory and > > its included files? especially since it's just done once, upon startup, > > i think it's negligible overhead. > > If using --demon; else it's done each time. (I agree is negligible > compared to the rest of things dspam is doing).
Indeed, I didn't think of that use case. Then again, I can't think of
any reasonably sized deployment that wouldn't run dspam as --daemon...
> > > so if this needed (required by hier(7) or something) on debian and it
> > > needs to be included upstream develop the patch to work for the rest of
> > > us as well.
> >
> > It is required on debian because as part of the Debian Policy, it is
> > forbidden for a package to edit another's files (so the mysql package
> > can't edit dspam.conf directly).
>
> I don't understand why mysql package would want to do that, but that's
> not important (I'm not familiar with Debian). If Debian and deviates
> needs it then it should be in.
I confirm that the Debian package strongly depends on that for its
magical autoconfiguration. Basically, the way it works is that when you
install the package, you get prompted for the mysql credentials and the
package writes the configuration file in dspam.d/mysql or something.
> > As for "working for the rest of us", I don't see how the patch breaks
> > anything for "the rest of us"...
>
> :-)
>
> Let's hide it behind a configure switch or OS check then; at very least
> it needs to respect PREFIX (sysconfdir) - which the current patch
> doesn't since it has that /etc hard-coded in it; having I'd really like to
> avoid having any of us maintain local patches to make it work right on
> our particular OS.
> Have it
> + Include @sysconfdir@/dspam/dspam.d/
> _if_ that dir exists should be enough.
>
> Does this sound OK to you?
That would be excellent. Besides, I was mostly jumping the gun and don't
have anything constructive to bring in besides trying to defend the
debian patchset.. ;)
Thanks for the feedback,
A.
--
L'ennui avec la grande famille humaine, c'est que tout le monde veut
en être le père.
- Mafalda
signature.asc
Description: Digital signature
