Stephen Leake <[EMAIL PROTECTED]> writes: > Michael Olson <[EMAIL PROTECTED]> writes: > >> * Make all dvc-log calls take a second last-n argument, so that C-x V L >> works again. My previous patch was for C-x V l, which is actually >> dvc-changelog. > > Sorry again; I'll do better at fixing the other backends in the > future. > > Apropos of this; do we really need both dvc-log and dvc-changelog?
To me, it makes sense to have both in the user-interface. But that can be done by having simply a different ewoc-printer for a revlist-mode. (historically, we used to have both command do really different things, because tla had "log" and "changelog" commands, and we managed them in a really different way). > Similarly, dvc-delta and dvc-diff are very similar; Yes, they're supposed to do very similar things. The idea is that dvc-diff means "diff against the working tree" while dvc-delta means "diff two revisions". Both have to appear in the user interface (diff should not prompt anything and show the diff between working tree and the last revision, while delta should prompt for two revisions). Ideally, diff should be a very short wrapper around delta (mostly the same argument list, with a different "(interactive ...)" statement). If anyone has a better proposal to name what we call "delta", that may be an improvement (diff-between? diff-revisions? ...) > I don't understand why we need both dvc-revlist-refresh-fn and > dvc-buffer-refresh-function? We probably don't... -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
