Stephen Leake <[EMAIL PROTECTED]> writes: > Matthieu Moy <[EMAIL PROTECTED]> writes: > >> Stephen Leake <[EMAIL PROTECTED]> writes: >> >>> You do a partial commit from a status buffer by marking the files you >>> want to commit. The dvc-status-mode post commit action would check for >>> marked files; if there are some, delete just those from the ewoc. >>> Otherwise, delete all from the ewoc. >> >> Since commit knows which files it's commiting, is should use it when >> cleaning-up the status buffer. > > That's exactly what I'm suggesting; the list of files being commited > is the marked files (or all files if none are marked).
What I'm suggesting is to keep the list of files to commit and to pass it to the commit hook. Commit does not just take "the list of marked files". It takes "the list of marked files /in the buffer you're comming from/". The status buffer doesn't know which buffer to take the list from. So, instead of status-buffer ---[list]---> commit status-buffer ---[list]---> cleanup I'm suggesting status-buffer ---[list]---> commit ----[list]---> cleanup. diff-buffer ----[list]-----/ (that's not much difference anyway). >> (e.g. clean up the status buffer while the commit was done from the >> diff-buffer, or any other kind of partial commit that we may add in >> the future, who knows ...). > > I don't see why you would have both a diff buffer and a status buffer > view of the same information. But if you did, they should both be > cleaned up together. Yes, but both should be cleaned-up according to the same list. You can mark files in the diff buffer, then commit, and you want the status buffer to be cleaned-up according to the list in diff buffer. -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
