Michael Olson <[EMAIL PROTECTED]> writes: > Stephen Leake <[EMAIL PROTECTED]> writes: > >> Michael Olson <[EMAIL PROTECTED]> writes: >> >>> Committed revision 294 to http://mwolson.org/bzr/dvc/ >>> >>> dvc-log-edit-done: Snarf the current prefix argument >>> >>> This allows C-u C-c C-c in a log edit buffer to actually work for >>> xgit. >> >> What does C-u mean in this context? >> >> Please describe it in the doc string for dvc-log-edit-done, so other >> back-ends can implement it. > > It means whatever backends want it to mean. It's just a "slot". In the > case of xgit, it means "reverse the value of xgit-use-index for this > commit". I already explained the xgit-specific part in an earlier log > message for the changes that modified xgit.
Hmm. I'm not sure back-end implementation-dependent arguments are a good thing in the DVC front-end. But this one seems fairly benign. At least let's document it in dvc-unified. How about: (define-dvc-unified-command dvc-log-edit-done (&optional arg) "Commit and close the log buffer. Optional ARG is back-end specific." > The nice thing about adding the dvc-remove-optional-args function is > that &optional args in a define-dvc-unified-command function can truly > be optional -- they don't have to be implemented in every single > backend. Before, that wasn't the case. Well, they had to be _declared_; they could still be ignored. That said, dvc-remove-optional-args is a nice improvement. -- -- Stephe _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
