Toby Allsopp <[EMAIL PROTECTED]> writes:

> Committed revision 329 to 
> http://bazaar.launchpad.net/~toby-mi6/dvc/toby_allsopp
>
> dvc-gnus: Stop xgit from clobbering key bindings.
>   
>   * lisp/xgit-gnus.el (xgit-insinuate-gnus): Don't clobber bindings in
>     gnus-summary-dvc-submap.

,----
| --- lisp/xgit-gnus.el 2007-11-04 11:52:25 +0000
| +++ lisp/xgit-gnus.el 2008-01-30 19:03:57 +0000
| @@ -35,20 +35,10 @@
|  
|  ;;;###autoload
|  (defun xgit-insinuate-gnus ()
| -  "Integrate Xgit into Gnus.
| -The following keybindings are installed for gnus-summary:
| -K t s `xgit-gnus-article-view-status-for-apply-patch'
| -K t v `xgit-gnus-article-view-patch'
| -
| -The following keybindings are ignored:
| -K t l"
| +  "Integrate Xgit into Gnus."
|    (interactive)
| -  (dvc-gnus-initialize-keymap)
| -  (define-key gnus-summary-dvc-submap [?s]
| -    'xgit-gnus-article-view-status-for-apply-patch)
| -  (define-key gnus-summary-dvc-submap [?v]
| -    'xgit-gnus-article-view-patch)
| -  (define-key gnus-summary-dvc-submap [?l] 'ignore))
| +  ;; bindings are set up by dvc-insinuate-gnus
| +  )
|  
|  (defcustom xgit-apply-patch-mapping nil
|    "*Working directories in which patches should be applied.
`----

I see your point.

But I would also like to make
xgit-gnus-article-view-status-for-apply-patch and
xgit-gnus-article-view-patch somehow available.

The proper fix would be to call these functions from the dvc dispatchers:

K t v           dvc-gnus-article-view-patch
=> should call  xgit-gnus-article-view-patch

K t s           create a new dispatcher function: 
dvc-gnus-article-view-status-for-apply-patch
=> should call xhg-gnus-article-view-status-for-import-patch or
               xgit-gnus-article-view-status-for-apply-patch

I merged your patch, because it is a first step in the direction I
described above.


Stefan.

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to