Hello,
It seem dvc-bookmarks-add-partner is broken:
it use a list method (car) on a structure.
so it fail with this error:

,----
| format: Wrong type argument: listp, [cl-struct-dvc-bookmark .....
`----

So i modify dvc-bookmarks-add-partner like that:
(i change the car with an aref)
(i add an element :nickname to the make-...)

,----
| (defun dvc-bookmarks-add-partner ()
|   (interactive)
|   (let* ((cur-data (dvc-bookmarks-current-bookmark))
|          (partner-url (read-string (format "Add partner to '%s': " (aref 
cur-data 1)))))
|     (if (not (member partner-url (dvc-bookmarks-get-partner-urls)))
|         (progn
|           (setf (dvc-bookmark-properties cur-data)
|                 (append (dvc-bookmark-properties cur-data)
|                         (list (list 'partner
|                                     (make-dvc-bookmark-partner :url 
partner-url :nickname nil)))))
|           (dvc-trace "dvc-bookmarks-add-partner %s" cur-data))
|       (message "%s is already a partner for %s"
|                partner-url (dvc-bookmark-name cur-data)))))
`----

That's working , now i can have that in my bookmarks now:

,----
| traverse-work-el
|   Partner (~/labo/traverse-module/ nil)
`----

And the function dvc-bookmarks-properties return for this bookmark:

,----
| ((local-tree "~/labo/traverse-work-el/") 
|  (push-locations ("ssh://thievol//home/thierry/labo/traverse-work-el")) 
|  (partner ("~/labo/traverse-module/" nil)))
`----

Is it correct?
How Partner is intended to work in dvc? (i use hg).

Thanks.
-- 
A + Thierry
Pub key: http://pgp.mit.edu


_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to