() Stephen Leake <[EMAIL PROTECTED]>
() Fri, 01 Aug 2008 04:15:36 -0400
This gives me some build errors:
Thanks for the bug reports.
make -r
cd lisp; make
make[1]: Entering directory `/Gnu/dvc/lisp'
srcdir=. otherdirs="" emacs -batch -q --no-site-file -l ./dvc-build.el -f
dvc-build-autoloads .
Env var `otherdirs' not set
Since the default is for 'otherdirs' to be empty, this can be fixed by
patching dvc-build.el:
Interesting. On my system, i see:
(let ((process-environment (cons "unlikely=" process-environment)))
(getenv "unlikely"))
=>""
I suppose you see =>nil (can you confirm?).
(defvar otherdirs (or (getenv "otherdirs")
""))
Yeah, that was the original construct. I thought more strictness would help,
but that depends on the above behavior (i.e., =>""). I have changed the code
as you suggest (patch attached).
That lets the first build complete. But then if I rerun 'make' (just
to be sure), I get: [details]
I will address this in another message.
Otherwise, this build process does look much cleaner.
Unfortunately, clean but broken is still broken. :-/
Sorry for the inconvenience.
thi
________________________________________
commit cf4fda4cdc632b5ba4ee467698b9fd9895431177
Author: Thien-Thi Nguyen <[EMAIL PROTECTED]>
Date: Fri Aug 1 12:02:26 2008 +0200
Fix bug: Relax env var `otherdirs' check for "make all".
This bug was introduced by "Consolidate build functionality into
dvc-build.el" (commit 17e23cacdcf4da83a795e4a19638dc180838d742).
* lisp/dvc-build.el (otherdirs): Don't signal error if value of
env var `otherdirs' is nil; revert to previous handling, i.e.,
assign "" to Lisp variable `otherdirs' in that case.
diff --git a/lisp/dvc-build.el b/lisp/dvc-build.el
index f2d00ea..626e088 100644
--- a/lisp/dvc-build.el
+++ b/lisp/dvc-build.el
@@ -37,7 +37,10 @@ (unless noninteractive
(defvar srcdir (or (getenv "srcdir")
(error "Env var `srcdir' not set")))
(defvar otherdirs (or (getenv "otherdirs")
- (error "Env var `otherdirs' not set")))
+ ;; We used to `error' as for `srcdir' here, but on some
+ ;; systems, if the value is "", `getenv' returns nil, so
+ ;; we can't be too strict. Reported by Stephen Leake.
+ ""))
;; Standard
_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev
