Hi,
dvdnav_go_up ignores the return value of vm_jump_up, and always returns
DVDNAV_STATUS_OK, The calling code cannot therefore determine whether
the jump was successful or not.
The attached patch evaluates the return value from vm_jump_up and passes
this back to the caller.
Regards,
Richard.
Index: .
===================================================================
--- . (revision 1257)
+++ . (working copy)
@@ -268,9 +268,11 @@
dvdnav_status_t dvdnav_go_up(dvdnav_t *this) {
/* A nice easy function... delegate to the VM */
+ int32_t retval;
+
pthread_mutex_lock(&this->vm_lock);
- vm_jump_up(this->vm);
+ retval = vm_jump_up(this->vm);
pthread_mutex_unlock(&this->vm_lock);
- return DVDNAV_STATUS_OK;
+ return retval ? DVDNAV_STATUS_OK : DVDNAV_STATUS_ERR;
}
_______________________________________________
DVDnav-discuss mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss
