On Friday 22 February 2013 16:57:49 Erik Auerswald wrote: > On 02/18/2013 05:55 AM, Mike Frysinger wrote: > > On Saturday 09 February 2013 16:18:50 Erik Auerswald wrote: > >> the first attached patch removes preprocessor checks for _LIBC, because > >> libdvdread is not GNU Libc and does never #define _LIBC. > > > > the files you're modifying are copied from elsewhere. > > Copied once, there is nobody trying to keep them up to date. They should > have been cleaned up back then, of course. > > To clarify: it is _not_ the question if upstream changed anything in > these files since they were copied. The issue is that taking a random > code snapshot and keeping it that way without thought is the very > definition of bitrot.
is the code not working ? failing to build ? something else ? if the code is still working, then no, it is not rotting at all. if you did hit a bug, then simply grab a newer version from upstream. > > hacking away at it gains literally nothing. > > I disagree. > > > what exactly is the point ? for getopt.c, it's not like > > you really improved it -- the file is still full of portability hacks > > from all over. > > Every simplification is an improvement. not really. the point of this code is to not be read directly. it's a generated blob maintained elsewhere. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ DVDnav-discuss mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss
