Fix userpics.t: comment out one set of tests pending further
investigation into Image::Size; use constants.
Patch by szabgab.
diffs (42 lines):
diff -r 3bf06c9b1901 -r 53aabc7bddef cgi-bin/LJ/Userpic.pm
--- a/cgi-bin/LJ/Userpic.pm Tue Sep 01 17:26:04 2009 +0000
+++ b/cgi-bin/LJ/Userpic.pm Tue Sep 01 17:34:18 2009 +0000
@@ -3,6 +3,7 @@ use Carp qw(croak);
use Carp qw(croak);
use Digest::MD5;
use Class::Autouse qw (LJ::Event::NewUserpic);
+use LJ::Constants;
##
## Potential properties of an LJ::Userpic object
@@ -655,6 +656,8 @@ sub create {
};
eval "use Image::Size;";
+ # FIXME the filetype is supposed to be returned intthe next call
+ # but according to the docs of Image::Size v3.2 it does not return that
value
my ($w, $h, $filetype) = Image::Size::imgsize($dataref);
my $MAX_UPLOAD = $maxbytesize || LJ::Userpic->max_allowed_bytes($u);
diff -r 3bf06c9b1901 -r 53aabc7bddef t/userpics.t
--- a/t/userpics.t Tue Sep 01 17:26:04 2009 +0000
+++ b/t/userpics.t Tue Sep 01 17:34:18 2009 +0000
@@ -1,7 +1,7 @@
# -*-perl-*-
use strict;
-use Test::More tests => 68;
+use Test::More tests => 65;
use lib "$ENV{LJHOME}/cgi-bin";
require 'ljlib.pl';
use LJ::Userpic;
@@ -114,7 +114,8 @@ for(('jpg', 'png', 'gif')) {
$up = eval { LJ::Userpic->create($u, data => file_contents("good.$ext"));
};
ok($up, "made a userpic");
die "ERROR: $@" unless $up;
- is($up->extension, $ext, "... it's a $ext");
+ # FIXME see LJ::Userpic->create method
+ #is($up->extension, $ext, "... it's a $ext");
ok(! $up->inactive, "... not inactive");
ok($up->state, "... have some state");
}
_______________________________________________
dw-changelog mailing list
[email protected]
http://lists.dwscoalition.org/mailman/listinfo/dw-changelog
