Use strict in all S2Theme files.
Patch by kareila.
diffs (221 lines):
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/bases.pm
--- a/cgi-bin/LJ/S2Theme/bases.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/bases.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::bases;
package LJ::S2Theme::bases;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2r" => "two-columns-right" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/basicboxes.pm
--- a/cgi-bin/LJ/S2Theme/basicboxes.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/basicboxes.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::basicboxes;
package LJ::S2Theme::basicboxes;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/blanket.pm
--- a/cgi-bin/LJ/S2Theme/blanket.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/blanket.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::blanket;
package LJ::S2Theme::blanket;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/boxesandborders.pm
--- a/cgi-bin/LJ/S2Theme/boxesandborders.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/boxesandborders.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::boxesandborders;
package LJ::S2Theme::boxesandborders;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/brittle.pm
--- a/cgi-bin/LJ/S2Theme/brittle.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/brittle.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::brittle;
package LJ::S2Theme::brittle;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "2l" => "two-columns-left", "2r" => "two-columns-right" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/colorside.pm
--- a/cgi-bin/LJ/S2Theme/colorside.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/colorside.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::colorside;
package LJ::S2Theme::colorside;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/core2base.pm
--- a/cgi-bin/LJ/S2Theme/core2base.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/core2base.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::core2base;
package LJ::S2Theme::core2base;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/crossroads.pm
--- a/cgi-bin/LJ/S2Theme/crossroads.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/crossroads.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::crossroads;
package LJ::S2Theme::crossroads;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/drifting.pm
--- a/cgi-bin/LJ/S2Theme/drifting.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/drifting.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::drifting;
package LJ::S2Theme::drifting;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "2l" => "two-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/easyread.pm
--- a/cgi-bin/LJ/S2Theme/easyread.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/easyread.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::easyread;
package LJ::S2Theme::easyread;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/fluidmeasure.pm
--- a/cgi-bin/LJ/S2Theme/fluidmeasure.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/fluidmeasure.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::fluidmeasure;
package LJ::S2Theme::fluidmeasure;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/funkycircles.pm
--- a/cgi-bin/LJ/S2Theme/funkycircles.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/funkycircles.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::funkycircles;
package LJ::S2Theme::funkycircles;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/modish.pm
--- a/cgi-bin/LJ/S2Theme/modish.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/modish.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::modish;
package LJ::S2Theme::modish;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/modular.pm
--- a/cgi-bin/LJ/S2Theme/modular.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/modular.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::modular;
package LJ::S2Theme::modular;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/negatives.pm
--- a/cgi-bin/LJ/S2Theme/negatives.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/negatives.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::negatives;
package LJ::S2Theme::negatives;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/nouveauoleanders.pm
--- a/cgi-bin/LJ/S2Theme/nouveauoleanders.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/nouveauoleanders.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::nouveauoleanders;
package LJ::S2Theme::nouveauoleanders;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/refriedtablet.pm
--- a/cgi-bin/LJ/S2Theme/refriedtablet.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/refriedtablet.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::refriedtablet;
package LJ::S2Theme::refriedtablet;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/skittlishdreams.pm
--- a/cgi-bin/LJ/S2Theme/skittlishdreams.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/skittlishdreams.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::skittlishdreams;
package LJ::S2Theme::skittlishdreams;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "2r" => "two-columns-right", "2l" => "two-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/steppingstones.pm
--- a/cgi-bin/LJ/S2Theme/steppingstones.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/steppingstones.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::steppingstones;
package LJ::S2Theme::steppingstones;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/tranquilityiii.pm
--- a/cgi-bin/LJ/S2Theme/tranquilityiii.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/tranquilityiii.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::tranquilityiii;
package LJ::S2Theme::tranquilityiii;
use base qw( LJ::S2Theme );
+use strict;
sub layouts { ( "1" => "one-column", "2l" => "two-columns-left", "2r" =>
"two-columns-right", "3" => "three-columns-sides", "3r" =>
"three-columns-right", "3l" => "three-columns-left" ) }
sub layout_prop { "layout_type" }
diff -r 4b6f898a0beb -r dcd12cb12c67 cgi-bin/LJ/S2Theme/zesty.pm
--- a/cgi-bin/LJ/S2Theme/zesty.pm Tue Sep 07 20:38:17 2010 +0800
+++ b/cgi-bin/LJ/S2Theme/zesty.pm Tue Sep 07 13:05:35 2010 -0500
@@ -1,5 +1,6 @@ package LJ::S2Theme::zesty;
package LJ::S2Theme::zesty;
use base qw( LJ::S2Theme );
+use strict;
sub cats { qw() }
sub designer { "exampleusername" }
diff -r 4b6f898a0beb -r dcd12cb12c67 t/use-strict.t
--- a/t/use-strict.t Tue Sep 07 20:38:17 2010 +0800
+++ b/t/use-strict.t Tue Sep 07 13:05:35 2010 -0500
@@ -12,7 +12,6 @@ foreach my $line (@files) {
next unless $path =~ /\.(pl|pm)$/;
# skip stuff we're less concerned about or don't control
next if $path =~ m:\b(doc|etc|fck|miscperl|src|s2)/:;
- next if $path =~ m:/S2Theme/:;
$check{$rel} = 1;
}
_______________________________________________
dw-changelog mailing list
[email protected]
http://lists.dwscoalition.org/mailman/listinfo/dw-changelog
