Don't call this method twice; second time short-circuits because the 
first time took care of the quoting, leaving us with the focus on the wrong 
element.

        Patch by Alicia, Erin, Josh, and Will of <user name="teamdestroyer">. 

diffs (12 lines):

diff -r 0f5715b82c54 -r e3bd0ee13d78 cgi-bin/LJ/Talk.pm
--- a/cgi-bin/LJ/Talk.pm        Wed Oct 13 12:17:23 2010 +0800
+++ b/cgi-bin/LJ/Talk.pm        Wed Oct 13 12:21:07 2010 +0800
@@ -2054,7 +2054,7 @@ sub js_quote_button {
     my ( $element, $hidebutton ) = @_;
     return '' unless $element;
     my $button = LJ::ejs( '<input type="button" value="Quote"'
-                        . ' onmousedown="quote();" onclick="quote();" />' );
+                        . 'onclick="quote();" />' );
     $button = '' if $hidebutton;
     my $buttontext = "document.write('&nbsp;&nbsp;$button')";
     if ( $element eq 'body' ) {
_______________________________________________
dw-changelog mailing list
[email protected]
http://lists.dwscoalition.org/mailman/listinfo/dw-changelog

Reply via email to