Better fix for LJ::Comment.
Patch by kareila.
diffs (18 lines):
diff -r ffb219724843 -r b54dd928e62c cgi-bin/LJ/Comment.pm
--- a/cgi-bin/LJ/Comment.pm Wed Nov 03 13:45:48 2010 +0800
+++ b/cgi-bin/LJ/Comment.pm Wed Nov 03 13:48:13 2010 +0800
@@ -93,12 +93,9 @@ sub instance {
$self->{journalid} = LJ::want_userid($uuserid) or
croak("invalid journalid parameter");
- no warnings 'uninitialized';
- # because $opts{jtalkid} and $opts{dtalkid} can be undef
- # and int() warns on those
- $self->{jtalkid} = int(delete $opts{jtalkid});
+ $self->{jtalkid} = int( delete( $opts{jtalkid} ) || 0 );
- if (my $dtalkid = int(delete $opts{dtalkid})) {
+ if ( my $dtalkid = int( delete( $opts{dtalkid} ) || 0 ) ) {
$self->{jtalkid} = $dtalkid >> 8;
}
_______________________________________________
dw-changelog mailing list
[email protected]
http://lists.dwscoalition.org/mailman/listinfo/dw-changelog
