Hush, too.
Patch by fu.
diffs (33 lines):
diff -r ce753f8e31a1 -r d35df8caa75a cgi-bin/LJ/Widget/S2PropGroup.pm
--- a/cgi-bin/LJ/Widget/S2PropGroup.pm Tue Nov 16 17:22:54 2010 +0800
+++ b/cgi-bin/LJ/Widget/S2PropGroup.pm Tue Nov 16 17:29:36 2010 +0800
@@ -224,7 +224,7 @@ sub render_body {
# need to print the header inside the foreach because we don't
want it printed if
# there's no props in this group that are also in this
subheader
unless ($header_printed) {
- my $prop_list_class;
+ my $prop_list_class = "";
$prop_list_class = " first" if $subheader_counter == 1;
$ret .= "<div class='subheader subheader-$propgroup on'
id='subheader__${propgroup}__${subheader}'>$subheaders{$subheader}</div>";
@@ -364,7 +364,7 @@ sub output_prop_element {
my $override = $prop_values{override};
my %values = split( /\|/, $prop->{values} || '' );
- my $existing_display = defined $values{$existing} ? $values{$existing} :
$existing;
+ my $existing_display = defined $existing && defined $values{$existing} ?
$values{$existing} : $existing;
$existing_display = LJ::eall($existing_display);
diff -r ce753f8e31a1 -r d35df8caa75a cgi-bin/htmlcontrols.pl
--- a/cgi-bin/htmlcontrols.pl Tue Nov 16 17:22:54 2010 +0800
+++ b/cgi-bin/htmlcontrols.pl Tue Nov 16 17:29:36 2010 +0800
@@ -363,7 +363,7 @@ sub html_color
## they don't appear when JavaScript is unavailable.
$ret .= "<script language=\"JavaScript\"><!--\n".
"document.write('<span style=\"border: 1px solid #000000; ".
- "padding-left: 2em; background-color: " .
ehtml($opts->{'default'}) . ";\" ".
+ "padding-left: 2em; background-color: " . ehtml($opts->{'default'}
|| "") . ";\" ".
"id=\"${htmlname}_disp\"";
if ($opts->{no_btn}) {
$ret .= " onclick=\"spawnPicker(findel(\\'${htmlname}\\')," .
_______________________________________________
dw-changelog mailing list
[email protected]
http://lists.dwscoalition.org/mailman/listinfo/dw-changelog
