On Fri, Sep 15, 2006 at 11:55:35AM +0200, Sander van Dijk wrote: > On 9/15/06, Anselm R. Garbe <[EMAIL PROTECTED]> wrote: > >Nah, there are not much simplifications possible without > >repeating mistakes which have been already done. Anyway, I > >believe I fixed this issue with a single check in focus() to not > >focus clients which are invisible. Jukka, can you recheck > >please? > > Hm, I'm not sure this is a good idea; I get the impression from > Jukka's report that the problem is that focus _stays_ somewhere it > isn't supposed to rather than being _put_ somewhere it shouldn't. This > check might work around some cases, but it doesn't really fix them; > dwm should never attempt to put/stay focus on something non-visible in > the first place (and so far, I haven't found the (missing?) code that > does allows this to happen). I think it's better to trace where the > focussetting goes wrong rather than work around it.
It's no workaround, it enforces the dwm policy. And the issue occures not because of a dwm fault, but because a nasty enternotify which is created by the server after dwm finished flushing the EnterNotifys, thus the fix is correct, because a non-visible window should never be focused. Regards, -- Anselm R. Garbe ><>< www.ebrag.de ><>< GPG key: 0D73F361
