> Well, I just wanted to make sure this happened as early as possible, since this is not related to what the package installs, I thought it was better to handle this in preinst, so that this can be also just removed at later times.
The thing about the preinst is that it runs super early, you can't even rely on the package's dependencies being installed. In this case we don't use any non-Essential tools, so it's OK, but often this is a problem. We don't *need* to use the preinst, since either the pkg is removed or not removed before we even start installing x11-common - at postinst time it's going to still be removed or it's going to get upgraded to the fixed version. There's a bug in x11-common. If the preinst check triggers twice (like on a xenial dist-upgrade and then again when you upgrade to bionic), the upgrade fails: Preparing to unpack .../x11-common_1%3a7.7+19ubuntu7.1_all.deb ... Moving obsolete conffile /etc/X11/Xsession.d/50_check_unity_support to /etc/X11/Xsession.d/50_check_unity_support.x11-back... mv: cannot stat '/etc/X11/Xsession.d/50_check_unity_support': No such file or directory dpkg: error processing archive /var/cache/apt/archives/x11-common_1%3a7.7+19ubuntu7.1_all.deb (--unpack): new x11-common package pre-installation script subprocess returned error exit status 1 Errors were encountered while processing: /var/cache/apt/archives/x11-common_1%3a7.7+19ubuntu7.1_all.deb E: Sub-process /usr/bin/dpkg returned an error code (1) Fixed that by adding a [ -f ] check, and then I made the same fixes as on the MP, expanded the changelog a bit, and uploaded to the silo (3299) for all releases. Please check my diffs - particularly the versions. Could you add some testcases for this please? Like - remove nux-tools from bionic-release (pre-sru), upgrade, reinstall nux-tools (no prompt) - remove nux-tools from bionic-proposed/updates (sru), upgrade, reinstall nux-tools (no prompt) - modify config file, remove nux-tools, upgrade, reinstall nux-tools (should prompt) - install nux-tools, upgrade, no prompt You end up with either no /etc/X11/Xsession.d/50_check_unity_support, its new contents or you are asked what to do if you've changed it before. Never the old content. -- You received this bug notification because you are a member of DX Packages, which is subscribed to nux in Ubuntu. Matching subscriptions: dx-packages https://bugs.launchpad.net/bugs/1768610 Title: leftover conffile forces GNOME is software rendering Status in nux package in Ubuntu: Fix Released Status in xorg package in Ubuntu: In Progress Status in nux source package in Xenial: Fix Committed Status in xorg source package in Xenial: Confirmed Status in nux source package in Artful: Fix Committed Status in xorg source package in Artful: Confirmed Status in nux source package in Bionic: Fix Committed Status in xorg source package in Bionic: In Progress Bug description: [ Impact ] GNOME shell and other 3D programs run using software rendering after unity removal. This SRU covers only the upgrade case or if nux-tools removal happens after this update, for people who already upgraded and in broken state another SRU will follow. [ Test case ] · Install xenial · Upgrade to bionic or artful (assuming you're using a GNOME session) · sudo apt remove nux-tools · log into your session . From terminal: - printenv LIBGL_ALWAYS_SOFTWARE Should print nothing (and return an error) Same should happen if you don't remove nux-tools but you change `/usr/lib/nux/unity_support_test` not to run properly (replace with a script exiting 1), but you're running a GNOME session. · If running Unity session instead, ensure that printenv LIBGL_ALWAYS_SOFTWARE equals 1 in case that you're running in an environment with no 3d support (VMs are easy tests) [ Regression Potential ] Unity desktops with no 3d support could not start anymore. =========================== After an upgrade from 17.10 to 18.04, I noticed that all gnome windows animations were gone. After some digging, it seems that gnome-session incorrectly assumes that my graphics has no acceleration, when in fact it does: it's a i5-2520M CPU @ 2.50GHz with Intel integrated graphics (i915 driver). I've tried this with and without the xserver-xorg-video-intel package (a.k.a. Intel driver) with the same behavior. The output of gnome-session-check-accelerated is: llvmpipe (LLVM 6.0, 256 bits) however the system should have DRM 2.0 capability. GL checks (e.g. glxinfo, glxgears produce the expected output from a working DRM system). mesa-utils and mesa-utils-extra are both installed. I can't find a work around. Perhaps there is something wrong with my install/upgrade? Everything else works fine, although the graphical transitions are no longer smooth. But it would be nice to restore the expected behavior. I have attached the log of 'journalctl -b0' ProblemType: BugDistroRelease: Ubuntu 18.04 Package: gnome-session 3.28.1-0ubuntu2 ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17 Uname: Linux 4.15.0-20-generic x86_64 ApportVersion: 2.20.9-0ubuntu7 Architecture: amd64 CurrentDesktop: ubuntu:GNOME Date: Wed May 2 13:06:00 2018 EcryptfsInUse: Yes InstallationDate: Installed on 2016-04-22 (739 days ago) InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1) ProcEnviron: PATH=(custom, no user) XDG_RUNTIME_DIR=<set> LANG=en_US.UTF-8 SHELL=/bin/bashSourcePackage: gnome-session UpgradeStatus: Upgraded to bionic on 2018-04-27 (5 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nux/+bug/1768610/+subscriptions -- Mailing list: https://launchpad.net/~dx-packages Post to : dx-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~dx-packages More help : https://help.launchpad.net/ListHelp
