On Tue, 2009-04-07 at 15:14 +0000, Mark Shuttleworth wrote: > Do we want to support append-on-replace at all? I find the "Joe is > offline/Joe is online" append really ugly. That should be a replace - > period. The append only makes sense when it WOULD have been two > consecutive messages. > > Ted, I think this sort of confusion is a result of us not being willing > to define appending more explicitly in the API. Because we wanted it to > be implicit and "easier for the developer", we've ended up with a > mishmash, both on our side (we aren't even implementing our own spec > correctly!) and in apps.
I'm sorry, perhaps I missed something in the conversation. We should absolutely not support append on replace. Because if we do that we end up in the case where we can't replace notifications that are appended. I think that's pretty much what the original bug report stated. If you send: "message A" -> append "message B" -> append That might be what you want to appear as: +----------------+ | message A | | message B | +----------------+ If for some reason "message A" changes then there is no way to refer to it if the replace is only "message B". -- Notification entries are not appended unless a replace is used https://bugs.launchpad.net/bugs/337394 You received this bug notification because you are a member of Notify OSD Developers, which is subscribed to Notify OSD. Status in Notify OSD: Fix Committed Bug description: Currently in the notify-osd code an append is only done if the type of update to the notification is a replace or update operation. This is incorrect and shoudl be changed to match the spec which states: "Whenever there are two or more notification bubbles in the queue that have the same title and come from the same program (as identified by its D-Bus ID), and both of them have hinted that they allow concatenation, Notify OSD should merge them into a single bubble" https://wiki.ubuntu.com/NotifyOSD#Concatenating%20existing%20bubbles The important phrasing here is "two or more notification bubbles" not an updated bubble. The reason for this is that the way that it's implemented now removes some capability from applications. The application needs to have the ability to update appended bubbles. So if I have two bubbles: a) "hello" b) "hi there" And I decide that I want to change b to "oh, goodbye", if the append hint is used, and replace is used to specify append, the result will be: hello hi there oh, goodbye When the correct result should be hello oh, goodbye This is currently how the Pidgin-libnotify plugin sends bubbles, it ensures that all messages are unique bubbles but will reuse bubbles for cases like sign on and sign off so that they get updated properly. _______________________________________________ Mailing list: https://launchpad.net/~dx-team Post to : [email protected] Unsubscribe : https://launchpad.net/~dx-team More help : https://help.launchpad.net/ListHelp
