>-----Original Message----- >From: Benzi Weissman [mailto:[email protected]] >Sent: Wednesday, November 02, 2011 1:52 AM >To: [email protected] >Subject: [E1000-devel] BUG in ixgbe_clean_rx_irq()? > >Hi, > >last_rx is being updated only if NETIF_F_GRO is not defined - probably in >view that last_rx is being updated in the kernel in GRO code related. >However, this is not true. last_rx is being updated in the linux kernel in >the new generic packet receive handler stuff (bond_handle_frame) which is >not related to GRO and even introduced few kernel versions later than >GRO....which means your latest ixgbe won't work properly with bond in >kernel versions 2.6.29-2.6.38.
NETIF_F_GRO was first defined in kernel 2.6.29, previous to that the ixgbe driver included in the kernel updated last_rx. This is the patch (in 2.6.29) that removed updating last_rx in all/most drivers including ixgbe: http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=commitdiff;h=babcda74e9d96bb58fd9c6c5112dbdbff169e695 >From what I can tell the check for NETIF_F_GRO in ixgbe is in line with the kernel changes. Or am I missing something? Is the bug report based on code review, or an actual problem you are seeing with the driver? Thanks, Emil > >-- >Benzi. ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
