Patches can not be applied to the SF version. We applied them manually, driver
operates as expected. I will be glad if you include patches in SF tree. Thanks
a
lot :)
On 17.12.2011 07:03, Skidmore, Donald C wrote:
> Hey Bokhan,
>
> I messed up your patch we can't call ixgbe_update_stats() because it call's
> ixgbe_get_stats() itself. :P
>
> This patch should correct that:
>
> diff -p -u -r1.1965 -r1.1966
> --- ixgbe/linux/oplin/src/CORE/ixgbe_main.c 16 Dec 2011 21:08:02 -0000
> 1.1965
> +++ ixgbe/linux/oplin/src/CORE/ixgbe_main.c 16 Dec 2011 23:27:09 -0000
> 1.1966
> @@ -9750,7 +9750,11 @@ static struct net_device_stats *ixgbe_ge
> **/
> void ixgbe_update_stats(struct ixgbe_adapter *adapter)
> {
> - struct net_device_stats *net_stats = ixgbe_get_stats(adapter->netdev);
> +#ifdef HAVE_NETDEV_STATS_IN_NETDEV
> + struct net_device_stats *net_stats =&adapter->netdev->stats;
> +#else
> + struct net_device_stats *net_stats =&adapter->net_stats;
> +#endif /* HAVE_NETDEV_STATS_IN_NETDEV */
> struct ixgbe_hw *hw =&adapter->hw;
> struct ixgbe_hw_stats *hwstats =&adapter->stats;
> u64 total_mpc = 0;
>
> Thanks,
> -Don Skidmore<donald.c.skidm...@intel.com>
>
>> -----Original Message-----
>> From: Skidmore, Donald C
>> Sent: Friday, December 16, 2011 2:09 PM
>> To: 'Bokhan Artem'; Wyborny, Carolyn
>> Cc: e1000-devel@lists.sourceforge.net; Brandeburg, Jesse
>> Subject: RE: [E1000-devel] interface counters
>>
>> Hi Bokhan,
>>
>> I talked with Carolyn a bit and I believe this patch is what you are
>> looking for:
>>
>> diff -u -p -r1.1964 ixgbe_main.c
>> --- src/CORE/ixgbe_main.c 15 Dec 2011 22:17:55 -0000 1.1964
>> +++ src/CORE/ixgbe_main.c 16 Dec 2011 21:07:44 -0000
>> @@ -9730,12 +9730,15 @@ static void ixgbe_shutdown(struct pci_de
>> **/
>> static struct net_device_stats *ixgbe_get_stats(struct net_device
>> *netdev)
>> {
>> + struct ixgbe_adapter *adapter = netdev_priv(netdev);
>> +
>> + /* update the stats data */
>> + ixgbe_update_stats(adapter);
>> +
>> #ifdef HAVE_NETDEV_STATS_IN_NETDEV
>> /* only return the current stats */
>> return&netdev->stats;
>> #else
>> - struct ixgbe_adapter *adapter = netdev_priv(netdev);
>> -
>> /* only return the current stats */
>> return&adapter->net_stats;
>> #endif /* HAVE_NETDEV_STATS_IN_NETDEV */
>>
>> This is against our out of tree in house driver, but depending on how
>> old your driver is this should apply fine. I'll include this patch in
>> the new Source Forge drop early next year.
>>
>> The upstream driver should handle this a little better. Some of the
>> fields are updated on demand while others wait for the service task to
>> do it (every 2 seconds). I'm interested in whether or not you tried the
>> upstream driver and if so did it work for you? Or maybe a better
>> question would be which fields are you concerned aren't getting updated
>> fast enough?
>>
>> Thanks,
>> -Don Skidmore<donald.c.skidm...@intel.com>
>>
>>
>>> -----Original Message-----
>>> From: Bokhan Artem [mailto:a...@eml.ru]
>>> Sent: Thursday, December 15, 2011 9:44 AM
>>> To: Wyborny, Carolyn
>>> Cc: e1000-devel@lists.sourceforge.net; Brandeburg, Jesse
>>> Subject: Re: [E1000-devel] interface counters
>>>
>>> 15.12.2011 22:51, Wyborny, Carolyn пишет:
>>>> I will be updating the out of tree igb driver, hopefully today, but
>> by
>>> end of the week at worst case that has a fix for this on igb.
>>> What about ixgbe? More necessary for me.
>>>
>>>> Thanks,
>>>>
>>>> Carolyn
>>>>
>>>> Carolyn Wyborny
>>>> Linux Development
>>>> LAN Access Division
>>>> Intel Corporation
>>>>
>>>>
>>>
>>> -----------------------------------------------------------------------
>> -
>>> ------
>>> Learn Windows Azure Live! Tuesday, Dec 13, 2011
>>> Microsoft is holding a special Learn Windows Azure training event for
>>> developers. It will provide a great way to learn Windows Azure and what
>>> it
>>> provides. You can attend the event by watching it streamed LIVE online.
>>> Learn more at http://p.sf.net/sfu/ms-windowsazure
>>> _______________________________________________
>>> E1000-devel mailing list
>>> E1000-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/e1000-devel
>>> To learn more about Intel® Ethernet, visit
>>> http://communities.intel.com/community/wired
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
