On Thu, 2013-02-07 at 15:12 +0200, Michael S. Tsirkin wrote: > At the moment, macvtap crashes are observed if macvtap is attached > to an interface with LRO enabled. > The crash in question is BUG() in macvtap_skb_to_vnet_hdr. > This happens because several drivers set gso_size but not gso_type > in incoming skbs. > This didn't use to be the case: with intel cards on 3.2 and older > kernels, with qlogic - on 3.4 and older kernels, so it's a regression if > not a recent one. > The following patches fix this for qlogic, broadcom and intel drivers. > > I tested that the patch fixes the crash for ixgbe but > don't have qlogic/broadcom hardware to test. > I also only tested TCPv4. > > Please review, and consider for 3.8. > > Changes from v1: > - added missing htons as suggested by Eric > - backported the relevant bits from > cbf1de72324a8105ddcc3d9ce9acbc613faea17e for bnx2x
I still don't think macvtap should behave inconsistently with forwarding and the bridge device. We need a consensus as to whether transformation by LRO is allowable before making changes one way or the other. If we're going to allow it then inet_lro also needs this fix. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
