On 23.08.2013 04:15, Jeff Kirsher wrote:
> From: Jesse Brandeburg <[email protected]>
>
> This patch contains the transmit, receive, and napi routines, as well
> as ancillary routines.
>
> This file is code that is (will be) shared between the VF and PF
> drivers.
Just some small nitpicks.
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> new file mode 100644
> index 0000000..ceafef0
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
[...]
> +static void i40e_receive_skb(struct i40e_ring *rx_ring,
> + struct sk_buff *skb, u16 vlan_tag)
> +{
> + struct i40e_vsi *vsi = rx_ring->vsi;
> + struct i40e_q_vector *q_vector = rx_ring->q_vector;
> + u64 flags = vsi->back->flags;
> +
> + if (vlan_tag & VLAN_VID_MASK)
> + __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
Suggesting __constant_htons instead of htons here.
[...]
> +static int i40e_tso(struct i40e_ring *tx_ring, struct sk_buff *skb,
> + u32 tx_flags, __be16 protocol, u8 *hdr_len,
> + u64 *cd_type_cmd_tso_mss, u32 *cd_tunneling)
> +{
[...]
> + cd_cmd = I40E_TX_CTX_DESC_TSO;
> + cd_tso_len = skb->len - *hdr_len;
> + cd_mss = skb_shinfo(skb)->gso_size;
> + *cd_type_cmd_tso_mss |= ((u64)cd_cmd << I40E_TXD_CTX_QW1_CMD_SHIFT)
> + | ((u64)cd_tso_len
> + << I40E_TXD_CTX_QW1_TSO_LEN_SHIFT)
> + | ((u64)cd_mss << I40E_TXD_CTX_QW1_MSS_SHIFT);
Should use either tab or space after cd_cmd, cd_mss but please don't mix
them.
Stefan
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
