On Sun, 2014-03-23 at 14:26 -0600, Jean Sacren wrote:
> The commit 6494294f277fd ("i40e/i40evf: Use
> dma_set_mask_and_coherent") uses dma_set_mask_and_coherent() to
> replace dma_set_coherent_mask() for the benefit of return error.
> The conversion brings some confusion in error checking as whether
> against DMA_BIT_MASK(64) or DMA_BIT_MASK(32). For one, if error is
> zero, the check will be against DMA_BIT_MASK(64) twice. Fix this
> error checking by binding the check to the pertinent one.
> 
> Signed-off-by: Jean Sacren <[email protected]>
> Cc: Mitch Williams <[email protected]>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c     | 11 ++++++-----
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 11 ++++++-----
>  2 files changed, 12 insertions(+), 10 deletions(-)

Thanks Jean, I have added this to my queue.

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit 
http://communities.intel.com/community/wired

Reply via email to