> -----Original Message----- > From: xuyongjia...@gmail.com [mailto:xuyongjia...@gmail.com] > Sent: Monday, May 12, 2014 10:07 PM > To: eric.duma...@gmail.com > Cc: e1000-devel@lists.sourceforge.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Yongjian Xu > Subject: [E1000-devel] [PATCH] e1000: remove the check: skb->len<=0 > > From: Yongjian Xu <xuyongjia...@gmail.com> > > There is no case skb->len would be 0 or 'negative'. > Remove the check. > > Signed-off-by: Yongjian Xu <xuyongjia...@gmail.com> > --- > drivers/net/ethernet/intel/e1000/e1000_main.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > b/drivers/net/ethernet/intel/e1000/e1000_main.c > index 27058df..660971f 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > @@ -3105,11 +3105,6 @@ static netdev_tx_t e1000_xmit_frame(struct > sk_buff *skb, > */ > tx_ring = adapter->tx_ring; > > - if (unlikely(skb->len <= 0)) { > - dev_kfree_skb_any(skb); > - return NETDEV_TX_OK; > - } > - > /* On PCI/PCI-X HW, if packet size is less than ETH_ZLEN, > * packets may get corrupted during padding by HW. > * To WA this issue, pad all small packets manually. > -- > 1.9.1 What is the exact problem that this is fixing? Did you have a test case that showed a problem with it?
Cheers, John ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
