Hi
I also tried this patch but didn't worked.
Created ticket as Emil suggested,
https://sourceforge.net/p/e1000/bugs/524/
Thank you, blackluck
On 2016. April 28. 13:20:23 zhuyj wrote:
> Hi, all
>
> About the patch "ixgbe: do not call check_link for ethtool in
> ixgbe_get_settings()", I tried to make a similar patch in i40e nic driver.
> The patch is as below. This patch is based on the latest linux kernel. I
> am not sure that this patch can fix this problem.
> Please make tests and let me know the test result.
>
> Hi, Emil
>
> Please comment on the following patch. Thanks a lot.
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index 784b165..56a2844 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -489,9 +489,8 @@ static int i40e_get_settings(struct net_device
*netdev,
> struct i40e_pf *pf = np->vsi->back;
> struct i40e_hw *hw = &pf->hw;
> struct i40e_link_status *hw_link_info = &hw->phy.link_info;
> - bool link_up = hw_link_info->link_info & I40E_AQ_LINK_UP;
>
> - if (link_up)
> + if (netif_carrier_ok(netdev))
> i40e_get_settings_link_up(hw, ecmd, netdev, pf);
> else
> i40e_get_settings_link_down(hw, ecmd, pf);
>
> Zhu Yanjun
>
> On 04/27/2016 06:52 PM, Laszlo Fekete wrote:
> > Hi,
> >
> > okay, I think understand your point, what could be the problem.
> >
> > As I see in 4.5 kernel the bonding patch already there, so I need only
> > patch i40e driver.
> >
> > I wanna try it with latest i40e driver (1.5.18), but there are too
> > much difference from that ixgbe patch so can't really patch with that
> > and I'm not really familiar with it's source.
> >
> > Maybe could you give me a patch for i40e_main.c?
> >
> > Best regards, blackluck
> >
> > On 2016. April 27. 16:56:25 zhuyj wrote:
> > > Hi,
> > >
> > >
> > >
> > > The patches are too many. Based on the latest linux kernel, I
modified
> > >
> > > the patch in the link:http://patchwork.ozlabs.org/patch/561848/
> > >
> > >
> > >
> > > If the root cause is correct, the following patch should fix this
> > >
> > > problem. This patch is based on the analysis.
> > >
> > > And it is only for test. Please let me know the test result.
> > >
> > >
> > >
> > > Thanks a lot.
> > >
> > > Zhu Yanjun
> > >
> > >
> > >
> > > From 57602f5ceafb2bfddfe222ea63ff7444179d8ac9 Mon Sep 17
00:00:00 2001
> > >
> > > From: Zhu Yanjun <zyjzyj2...@gmail.com>
> > >
> > > Date: Wed, 27 Apr 2016 01:51:51 -0700
> > >
> > > Subject: [PATCH 1/1] i40e: synchronize link_up and link_speed of
a slave
> > >
> > > interface
> > >
> > >
> > >
> > > Similar to ixgbe nic, i40e nic needs the similar logic to handle
> > >
> > > the synchronization of link_up and link_speed of a slave interface.
> > >
> > > To all the slave interfaces, the link_speed and link_up should be
> > >
> > > synchronized since the time span between link_up and
link_speed
> > >
> > > will make some virtual NICs not work well, such as a bonding
driver
> > >
> > > in 802.3ad mode.
> > >
> > >
> > >
> > > Signed-off-by: Zhu Yanjun <zyjzyj2...@gmail.com>
> > >
> > > ---
> > >
> > > drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++
> > >
> > > 1 file changed, 4 insertions(+)
> > >
> > >
> > >
> > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > >
> > > b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > >
> > > index 3449129..6bb178c 100644
> > >
> > > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > >
> > > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > >
> > > @@ -6133,6 +6133,10 @@ static void i40e_link_event(struct
i40e_pf *pf)
> > >
> > > new_link == netif_carrier_ok(vsi->netdev)))
> > >
> > > return;
> > >
> > >
> > >
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
