Sorry... its a mistake from my side. While back porting these changes to
K3.18, I missed following lines
spin_lock_init(&adapter->tmreg_lock);
INIT_WORK(&adapter->ptp_tx_work, igb_ptp_tx_work);
and that is how I came to this wrong conclusion. Anyway, now I checked once
again and you changes are working indeed.
Thanks....
On Thu, May 12, 2016 at 11:34 PM, Keller, Jacob E <jacob.e.kel...@intel.com>
wrote:
> I’m not sure what you mean? Those two functions are work items which are
> being used in the work queue. We can’t remove them without breaking the ptp
> functionality..
>
>
>
> Maybe the patches are incorrectly not enabling these now?
>
>
>
> Thanks,
>
> Jake
>
>
>
> *From:* vidya sagar [mailto:sagar...@gmail.com]
> *Sent:* Thursday, May 12, 2016 11:01 AM
> *To:* Keller, Jacob E <jacob.e.kel...@intel.com>
> *Cc:* e1000-devel@lists.sourceforge.net
> *Subject:* Re: [PATCH] igb: properly start/stop PTP during suspend/resume
>
>
>
> Thanks a lot Jacob. Your patches 0 ~ 5 have solved the issue I'm facing.
>
> One minor comment. After these changes, I think we can remove
> both igb_ptp_tx_work() and igb_ptp_tx_hwtstamp() as they are no longer
> being used.
>
> Thanks again for the quick response, really appreciate it.
>
>
>
> On Wed, May 11, 2016 at 11:52 PM, Jacob Keller <jacob.e.kel...@intel.com>
> wrote:
>
> Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com>
> ---
>
> Vidya,
>
> I believe this is the correct patch, it seems that igb starts and stops
> ptp at probe and remove time, and wasn't stopping the work properly.
> This patch should resolve that. Let me know if this works in your
> environment. I will be submitting this through Jeff Kirsher's dev-queue
> soon.
>
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index 21727692bef6..8f740bc69fc3 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7527,6 +7527,8 @@ static int __igb_shutdown(struct pci_dev *pdev, bool
> *enable_wake,
> if (netif_running(netdev))
> __igb_close(netdev, true);
>
> + igb_ptp_stop(adapter);
> +
> igb_clear_interrupt_scheme(adapter);
>
> #ifdef CONFIG_PM
> @@ -7637,6 +7639,8 @@ static int igb_resume(struct device *dev)
> return -ENOMEM;
> }
>
> + igb_ptp_init(adapter);
> +
> igb_reset(adapter);
>
> /* let the f/w know that the h/w is now under the control of the
> --
> 2.8.1.493.g7b22612
>
>
>
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
