Hi Mickael,

I tried by using the container colors but, those colors may change if the
view is activated or not, so I should listen for those changes and update
the colors. I think it is too tricky, and not a good solution for
subclassing composites, that is a very common practice. But probably it is
just about the CSS rules of the theme, that are not "inclusive" enough. I
am following the guidelines of Lars in the bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=539592.

Thanks all,
Arian


On Fri, Sep 28, 2018 at 5:11 AM Mickael Istria <[email protected]> wrote:

>
>
> On Fri, Sep 28, 2018 at 11:03 AM Lars Vogel <[email protected]>
> wrote:
>
>> > But there could be better ways of doing this.
>>
>> One way would be to define such colors via preferences as the CSS can
>> style these preferences.
>
>
> To be honest, I fundamentally think that CSS is a bad answer for such
> use-case.
>
> In general, any special control is likely to want by default to reuse the
> parent background and so on, and would be more agile and portable
> dynamically choosing the best colors according to its container than by
> assuming a CSS is there to define the right color.
> CSS is still a bunch of hardcoded colors. If tomorrow Phaser Editor
> decides to go for the Hello Kitty theme, then your suggestion about CSS
> would require Phaser Editor to write specific code in order to work on the
> light pink background and not be drawn as white.
>
> CSS inheritance could be an intermediary solution here. Is it ignored? Or
> is it just that Canvas background color is not set in general and then
> while/default is used?
> _______________________________________________
> e4-dev mailing list
> [email protected]
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/e4-dev
_______________________________________________
e4-dev mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/e4-dev

Reply via email to