[ 
http://jira.nuxeo.org/browse/NXP-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=33790#action_33790
 ] 

Olivier Grisel commented on NXP-2171:
-------------------------------------

Example error message that is hard to debug (no document title or filename) 
since the exception is logged too deep in the call trace:

13:25:42,913 ERROR [AbstractTransformer] An error occured while trying to 
perform a transformation chain.
org.apache.poi.hpsf.IllegalPropertySetDataException: The property set claims to 
have a size of 16 bytes. However, it exceeds 16 bytes.
        at org.apache.poi.hpsf.Section.<init>(Section.java:255)
        at org.apache.poi.hpsf.PropertySet.init(PropertySet.java:454)
        at org.apache.poi.hpsf.PropertySet.<init>(PropertySet.java:249)
        at 
org.apache.poi.hpsf.PropertySetFactory.create(PropertySetFactory.java:61)
        at org.apache.poi.POIDocument.getPropertySet(POIDocument.java:97)
        at org.apache.poi.POIDocument.readProperties(POIDocument.java:74)
        at 
org.apache.poi.hssf.usermodel.HSSFWorkbook.<init>(HSSFWorkbook.java:171)
        at 
org.apache.poi.hssf.usermodel.HSSFWorkbook.<init>(HSSFWorkbook.java:148)
        at 
org.apache.jackrabbit.extractor.MsExcelTextExtractor.extractText(MsExcelTextExtractor.java:62)
        at 
org.nuxeo.ecm.platform.transform.plugin.jr.AbstractJRBasedTextExtractorPlugin.extractTextFromBlob(AbstractJRBasedTextExtractorPlugin.java:71)
        at 
org.nuxeo.ecm.platform.transform.plugin.jr.AbstractJRBasedTextExtractorPlugin.transform(AbstractJRBasedTextExtractorPlugin.java:48)
        at 
org.nuxeo.ecm.platform.transform.transformer.AbstractTransformer.transform(AbstractTransformer.java:174)
        at 
org.nuxeo.ecm.platform.transform.service.TransformService.transform(TransformService.java:205)


> AbstractTransform should not catch transformers exceptions
> ----------------------------------------------------------
>
>                 Key: NXP-2171
>                 URL: http://jira.nuxeo.org/browse/NXP-2171
>             Project: Nuxeo Enterprise Platform 5
>          Issue Type: Bug
>    Affects Versions: 5.1.3.2
>            Reporter: Olivier Grisel
>            Assignee: Thierry Delprat
>             Fix For: 5.2 M1
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> AbstractTransform should not catch transformer exception but throw them 
> instead.
> This would allow the caller to handle it correctly and help the developers 
> find which file attachment name in which Nuxeo document has triggered the  
> problem.
> The AbstractTransform is indeed two deep in the call stack and has no idea of 
> the Nuxeo document being transform and therefore cannot log all necessary 
> data  to make debugging easy.
> Fixing this problem requires an API change: add new throws declaration on the 
> method:
>     public List<TransformDocument> transform(
>             Map<String, Map<String, Serializable>> options,
>             TransformDocument... sources);
> Therefore this change cannot be implemented in the 5.1 branch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.nuxeo.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
ECM-tickets mailing list
[email protected]
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets

Reply via email to