[ 
http://jira.nuxeo.org/browse/NXP-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47073#action_47073
 ] 

Alexandre Russel commented on NXP-1899:
---------------------------------------

http://hg.nuxeo.org/nuxeo/nuxeo-core/rev/bdf80236e32b
http://hg.nuxeo.org/nuxeo/nuxeo-platform/rev/5a7ff61e0195

> DocumentModelImpl methods should not catch client exceptions
> ------------------------------------------------------------
>
>                 Key: NXP-1899
>                 URL: http://jira.nuxeo.org/browse/NXP-1899
>             Project: Nuxeo Enterprise Platform
>          Issue Type: Bug
>          Components: Core
>            Reporter: Olivier Grisel
>            Assignee: Alexandre Russel
>            Priority: Major
>             Fix For: 5.2 M4
>
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
>
> DocumentModelImpl tends to catch a lot of ClientException it without handling 
> then wich results in a hidden aborted transaction that causes the next 
> CoreSession / SearchService calls to crash later and  logs several kB of 
> "Could not find stateful bean xxxx" error logs that are very confusing to 
> debug.
> Offending methods are:
> DocumentModelImpl.getACP
> DocumentModelImpl.setACP
> DocumentModelImpl.getDataModel
> DocumentModelImpl.findAdapter
> Those methods should just not catch ClientException. This implies changing 
> the DocumentModel API to append " throws ClientException" to the prototypes 
> of those methods : this will break API compatibility and thus should be 
> advertised approprietly on the mailing list to inform developers tempted to 
> update.
> NB: Lifecycle related method should also throw ClientExceptions if the cannot 
> find a client instead of logging a error and continue as if the problem had 
> not occured.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.nuxeo.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
ECM-tickets mailing list
ECM-tickets@lists.nuxeo.com
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets

Reply via email to