[ 
https://jira.nuxeo.com/browse/NXP-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=106485#comment-106485
 ] 

Anahide Tchertchian commented on NXP-7941:
------------------------------------------

sample fix for this issue on the theme styling service (as an example for 
upgrade):
http://hg.nuxeo.org/nuxeo/nuxeo-theme/rev/c301d3e5ff66

> Remove ContributionFragmentRegistry#getContribution from the public API
> -----------------------------------------------------------------------
>
>                 Key: NXP-7941
>                 URL: https://jira.nuxeo.com/browse/NXP-7941
>             Project: Nuxeo Enterprise Platform
>          Issue Type: Task
>    Affects Versions: 5.4.2
>            Reporter: Anahide Tchertchian
>            Assignee: Anahide Tchertchian
>             Fix For: 5.5
>
>
> The method ContributionFragmentRegistry#getContribution applies all merging 
> logics again, but it should not be the one used by services to retrieved 
> merged contributions (as method contributionUpdated makes it possible to 
> store the merged resources locally) => remove it from public API as 
> developers can make this mistake.
> If they want to call it, they can always add a new public method on their 
> registry implementation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
ECM-tickets mailing list
ECM-tickets@lists.nuxeo.com
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets

Reply via email to