Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001219
--- Comment #11 from Ilija Kocho <[email protected]> 2011-10-11 21:39:04 BST --- (In reply to comment #7) > Created an attachment (id=1396) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1396) [details] > Variant modification needed by STM32 CL http://bugs.ecos.sourceware.org/attachment.cgi?id=1396&action=diff#ecos_clear/packages/hal/cortexm/stm32/var/current/include/var_io.h_sec7 Ethernet definitions are usually stored with Ethernet driver, either with C source or in a header file (I prefer the second). If you move it there than that would imply that names do not contain "_HAL_". http://bugs.ecos.sourceware.org/attachment.cgi?id=1396&action=diff#ecos_clear/packages/hal/cortexm/stm32/var/current/src/hal_diag.c_sec1 What is the reason for renaming of hal_stm32_serial_init() into hal_stm32_serial_init_channel() http://bugs.ecos.sourceware.org/attachment.cgi?id=1396&action=diff#ecos_clear/packages/hal/cortexm/stm32/var/current/src/stm32_misc.c_sec2 Changes like this may look attractive but (as well as previous one) may (will) break other user's applications. Conditional compilation may help but in this case I suggest to keep old code, it's simple and provides working conditions to all peripherals. http://bugs.ecos.sourceware.org/attachment.cgi?id=1396&action=diff#ecos_clear/packages/hal/cortexm/stm32/var/current/src/stm32_misc.c_sec3 Is this necessary? http://bugs.ecos.sourceware.org/attachment.cgi?id=1396&action=diff#ecos_clear/packages/hal/cortexm/stm32/var/current/src/stm32_misc.c_sec4 I'm referring to following: - hal_stm32_sysclk /= 2; + hal_stm32_sysclk = CYGARC_HAL_CORTEXM_STM32_INTERNAL_CLOCK / 2; If it works don't fix it :) Now some minor remarks: Comments like #endif // CYGINT_HAL_CORTEXM_STM32_CL>0 on some places are not consistent with their respective #ifs. And: (this is my personal only) #if CYGINT_HAL_CORTEXM_STM32_CL != 0 or #if CYGINT_HAL_CORTEXM_STM32_CL is more common than >0. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
