Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001291
--- Comment #47 from Ilija Kocho <[email protected]> 2012-02-12 12:15:56 GMT --- (In reply to comment #46) > Hi Ilija, > > I will check again the status of the new disclaimer and revert to you. > > However, I would like to fix Bug 1001449 first. I see in your attachment > (Flash > driver SST25XX SPI tests 120206) from Bug 1001450 > that you have defined CYGNUM_DEVS_FLASH_SPI_SS25XX_MAP_ADDR directly in the > test case (flash_sst25xx_test.c), instead of spreading > CYGNUM_DEVS_FLASH_SPI_SST25XX_DEV0_MAP_ADDR. Nice catch. Thank you for pointing this out. It is a ghost from old code. > > In my proposal (1001449), I suggested to have a platform specific include in > the test case C file that provides the configuration of the platform flash: > > #include CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL > > And CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL is defined in the platform CDL as > done other places: > > define_proc { > puts $::cdl_system_header "#define > CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL > <pkgconf/devs_flash_cortexm_a2f200_eval.h>" > } > > What do you think? I have defined CYGNUM_DEVS_FLASH_SPI_SST25XX_DEV0_MAP_ADDR in the driver CDL but you are right. Things like this, I would call them /configurable constants/ should come from the HAL. Every platform can have it's own address space. I am going to change it, only, I would parent CYGNUM_DEVS_FLASH_SPI_SST25XX_DEV0_MAP_ADDR (or CYGDAT_DEVS_FLASH_SPI_AT25DFXXX_PLF_CDL) by their respective FLASH drivers. Regards Ilija P.S. Speaking of HAL /configurable constants/, you may find interesting to see and comment (and I hope consider for Smartfusion) my discussion http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001397#c13 with Tomas Frydrych regarding consolidated /Interrupt Priority Scheme/. I think that it will be of help to application programmers for tuning real-time system behavior. You can see this feature implemented implemented in the latest Variant and Platform (as well as affected driver) attachments in Bug 1001450. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
