Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001561
--- Comment #34 from Ilija Kocho <[email protected]> 2012-07-11 08:12:14 BST --- Hi Jifl Thanks for comments. (In reply to comment #33) > Hi Nicolas, > > As well as Ilija's comments, I also have a few comments too before this is > committed: > [snip] . > > - I don't think the flash driver should be instantiated in kinetis_misc.c. It > should either go in kinetis_flash.c along with everything else, or go in > individual platform HALs, to allow them the ability to override or disable > (like the STM32 does with its internal flash driver). > FAOD I guess you are referring to devs/____/kinetis_flash.c . (Because there was a version with another kinetis_flash.c in HAL that contained only the flash driver entry. It was abandoned for reasons stated in comment #21). I vote for putting the driver entry with driver code since I don't see a need for different instances. Ilija -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
