A suggestion for ECS2:
(1) Remove the ability in ecs.properties
of setting: filter_state and filter_attribute_state.
(2) Consider differentiating between filters on/off through
method names and possibly class names.
The difficulties arise from:
(*) Using someone elses code where they have the property set
differently than your own code. Our project has run into
this with regard to Turbine -- Turbine uses ecs and expects
the filter_state to be false. Our other code however
has filter_state set to true. Fixing this is hard because
it involves visiting many lines of code, making changes like:
P p = new P().addElement(raw);
to:
P p = new P();
p.setFilterState(true);
p.addElement(raw);
Suggestion (1) would have prevented us getting into this mess.
Suggestion (2) would give us a convenient solution:
Instead of new P().addElement(), we could use:
new P().addFilteredElement()
I will probably implement (2) soon, unless someone says this is a
brain dead solution and they have a better solution.
-Nick Ide
--
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Archives and Other: <http://java.apache.org/main/mail.html>
Problems?: [EMAIL PROTECTED]
