On Thu, Jun 13, 2013 at 8:44 AM, Kirkendall, Garrett
<[email protected]> wrote:
> Attached is a patch that will generate an error if a region described within 
> an [FD] section will
> not fit within the FD section Size

>+                EdkLogger.error("GenFds", GENFDS_ERROR,
>+                                'FD %s size too small to fit region with 
>offset 0x%X and size 0x%X' \
>+                                % (self.FdUiName, PreviousRegionStart, 
>PreviousRegionSize))

I don't think you need the \ at the end of that line.

> This is my first time contributing a patch, so let me know what I did wrong.

It looks like you properly followed the Contributions.txt process.

Reviewed-by: Jordan Justen <[email protected]>

> Garrett Kirkendall
> SMTS Firmware Engineer
> AMD Technology & Engineering
> 7171 Southwest Parkway
> Austin, TX, 78735
> U.S.A.
> O: +(1) 512 602 3255
>
>   Visit us at: Facebook | amd.com

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
edk2-buildtools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel

Reply via email to